Closed mcculls closed 4 weeks ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | mcculls/improve-jffi-isolation |
git_commit_date | 1729502178 | 1729502678 |
git_commit_sha | f687c2d038 | 167dca9227 |
release_version | 1.42.0-SNAPSHOT~f687c2d038 | 1.42.0-SNAPSHOT~167dca9227 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-10-21T09:33:36 | 2024-10-21T09:40:28 |
git_branch | master | mcculls/improve-jffi-isolation |
git_commit_date | 1729502178 | 1729502678 |
git_commit_sha | f687c2d038 | 167dca9227 |
release_version | 1.42.0-SNAPSHOT~f687c2d038 | 1.42.0-SNAPSHOT~167dca9227 |
start_time | 2024-10-21T09:33:22 | 2024-10-21T09:40:15 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | mcculls/improve-jffi-isolation |
git_commit_date | 1729502178 | 1729502678 |
git_commit_sha | f687c2d038 | 167dca9227 |
release_version | 1.42.0-SNAPSHOT~f687c2d038 | 1.42.0-SNAPSHOT~167dca9227 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Isolates our embedded JFFI dependency from other versions that might be on the boot or system class-paths.
Motivation
Avoids some obscure linkage exceptions that can happen when multiple versions of JFFI are on the class-path.
Additional Notes
This PR contains two changes:
com.kenai.jffi
classes from our isolatiingDatadogClassLoader
com.kenai.jffi.Init
with a much simplerPatchInit
class that loads from the same isolating class-loaderNote we cannot fully shade JFFI (or the related JNR dependency) because it has a native component which would also need to be updated and recompiled for every platform.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMS-13480