Closed manuel-alvarez-alvarez closed 1 day ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | malvarez/iast-fix-callsites-super-ctor |
git_commit_date | 1732311036 | 1732482081 |
git_commit_sha | c8030bdceb | 0468adced4 |
release_version | 1.43.0-SNAPSHOT~c8030bdceb | 1.43.0-SNAPSHOT~0468adced4 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-11-24T22:39:51 | 2024-11-24T22:46:49 |
git_branch | master | malvarez/iast-fix-callsites-super-ctor |
git_commit_date | 1732311036 | 1732482081 |
git_commit_sha | c8030bdceb | 0468adced4 |
release_version | 1.43.0-SNAPSHOT~c8030bdceb | 1.43.0-SNAPSHOT~0468adced4 |
start_time | 2024-11-24T22:39:37 | 2024-11-24T22:46:35 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | malvarez/iast-fix-callsites-super-ctor |
git_commit_date | 1732311036 | 1732482081 |
git_commit_sha | c8030bdceb | 0468adced4 |
release_version | 1.43.0-SNAPSHOT~c8030bdceb | 1.43.0-SNAPSHOT~0468adced4 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Fixes an issue in IAST with call-sites instrumenting constructor super calls. The Java compiler generates different bytecode when the
<init>
method is called from anew
instruction or viasuper
:This PR ensures that the
CallSiteTransformer
is able to deal with both cases successfully.Motivation
One customer reported an issue when enabling IAST:
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-55918