Open mhlidd opened 3 days ago
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | mhlidd/check_valid_span_id |
git_commit_date | 1732562600 | 1732577529 |
git_commit_sha | 224dc1b6d9 | c2c4c3ef84 |
release_version | 1.44.0-SNAPSHOT~224dc1b6d9 | 1.43.0-SNAPSHOT~c2c4c3ef84 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
end_time | 2024-11-25T23:41:53 | 2024-11-25T23:48:53 |
git_branch | master | mhlidd/check_valid_span_id |
git_commit_date | 1732562600 | 1732577529 |
git_commit_sha | 224dc1b6d9 | c2c4c3ef84 |
release_version | 1.44.0-SNAPSHOT~224dc1b6d9 | 1.43.0-SNAPSHOT~c2c4c3ef84 |
start_time | 2024-11-25T23:41:40 | 2024-11-25T23:48:40 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Baseline | Candidate | |
---|---|---|
baseline_or_candidate | baseline | candidate |
git_branch | master | mhlidd/check_valid_span_id |
git_commit_date | 1732562600 | 1732577529 |
git_commit_sha | 224dc1b6d9 | c2c4c3ef84 |
release_version | 1.44.0-SNAPSHOT~224dc1b6d9 | 1.43.0-SNAPSHOT~c2c4c3ef84 |
Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.
What Does This Do
Adds a check to ensure that Span Links are only created in compound header extraction when the
SpanID
is valid.Motivation
This system-tests PR introduces a test to ensure that all libraries only create span links in distributed tracing header extraction when the
SpanID
is valid. This PR aims to implement this check in dd-trace-java and pass the test referenced.Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]