search

DataDog / dd-trace-js

JavaScript APM Tracer
https://docs.datadoghq.com/tracing/
Other
649 stars 306 forks source link

DeprecationWarning: Buffer #3546

Open imgalli opened 1 year ago

imgalli commented 1 year ago

Hi! We're seeing this error in the log that we're tracking back to protobuf.js, which is in turn a dep of dd-trace. Your module is the only reason for this dep to be included, is there a way you can upgrade or mitigate?

(node:7) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
ofhouse commented 1 year ago

We saw a similar message this morning, but tracked it back to the use of msgpack-lite (which is a direct dependency of dd-trace).

X-Ref: https://github.com/kawanet/msgpack-lite/issues/98

opeologist commented 1 year ago

any update on this ?

juancarlosjr97 commented 10 months ago

Any update on this?

swcm-mnestler commented 10 months ago

Given that the library was last updated 7 years ago and this issue still remains, it may be worth considering a different msgpack library

yelsayed commented 9 months ago

Keeping this thread alive.

Que3216 commented 8 months ago

Just wanted to check in -- is there any update on this? (looks like it's been open for 6 months now, and presumably is affecting every customer using dd-trace on modern Node?)

Que3216 commented 8 months ago

Looks like there is a fork that may fix this https://github.com/meetnow/msgpack-long-lite/commit/b7a42528919f05e2d61b13bc0fbd3b05b37fc300 ? (but haven't investigated closely)

kasleet commented 6 months ago

Any timeline on this?

juancarlosjr97 commented 4 months ago

:(...

ahmadnassri commented 1 month ago

so maybe we'll see this fixed in 2027???

JstnMcBrd commented 2 weeks ago

Corresponding issue in msgpack-lite