search

DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
496 stars 155 forks source link

[Feature] Group Redis resources under the same operation #1127

Open zBart opened 3 years ago

zBart commented 3 years ago

Is your feature request related to a problem? Please describe. Currently each PHP Redis call is traced under a separate operation: image

This makes is very difficult to see how many requests are actually being done, as it would mean having to click each operation and see. Additionally on the APM overview you can only see the primary operation count, which isn't a very good indication of how active the server is.

Describe the solution you'd like Under Java, Datadog logs all operations under the same operation (redis.query): image

This way you get a more accurate count of requests being done.

One change that might be needed is to group connects under a separate operation (for example redis.connect) because under PHP you generally connect every requests (vs Java which can have keep connections open), otherwise the numbers might get skewed.

morrisonlevi commented 3 years ago

Thanks for the feature request. This does look like it would make things more consistent. I'll talk to the product manager to see when it can get scheduled.

zghib commented 11 months ago

Any updates on this?

B-Galati commented 8 months ago

Hi @bwoebi! Would you have more info on this one?

It looks like a low hanging fruit that would have a great impact IMO :+1: