Closed axl89 closed 1 year ago
Would this fix the issue? Let me know if so and I'll create a PR.
diff --git a/datadog-setup.php b/datadog-setup.php
index 5e5d301..1067dfc 100644
--- a/datadog-setup.php
+++ b/datadog-setup.php
@@ -563,7 +563,7 @@ function install($options)
// phpcs:disable Generic.Files.LineLength.TooLong
$profilingExtensionRealPath = "$tmpArchiveProfilingRoot/ext/$extensionVersion/datadog-profiling$extensionSuffix.so";
// phpcs:enable Generic.Files.LineLength.TooLong
- $shouldInstallProfiling = file_exists($profilingExtensionRealPath);
+ $shouldInstallProfiling = (file_exists($profilingExtensionRealPath) && is_truthy($options[OPT_ENABLE_PROFILING]) );
if ($shouldInstallProfiling) {
$profilingExtensionDestination = $phpProperties[EXTENSION_DIR] . '/datadog-profiling.so';
@@ -572,7 +572,7 @@ function install($options)
// Appsec
$appsecExtensionRealPath = "{$tmpArchiveAppsecRoot}/ext/{$extensionVersion}/ddappsec{$extensionSuffix}.so";
- $shouldInstallAppsec = file_exists($appsecExtensionRealPath);
+ $shouldInstallAppsec = (file_exists($appsecExtensionRealPath) && is_truthy($options[OPT_ENABLE_APPSEC]));
if ($shouldInstallAppsec) {
$appsecExtensionDestination = $phpProperties[EXTENSION_DIR] . '/ddappsec.so';
@axl89 we intentionally install all extensions to give you the option of enabling them in the future through environment variables or through configuration.
In the case of appsec, we load the extension when not explicitly enabled as we want to give customers the option of enabling it through remote configuration if they wish to do so in the future.
You currently have the option of explicitly disabling it, in which case the extension will basically do nothing. You can do so by setting the following configuration in 98-ddtrace.ini
:
datadog.appsec.enabled = Off
Or using the equivalent environment variable DD_APPSEC_ENABLED
.
If you don't want to load the extension at all, you can also comment the relevant configuration line from 98-ddtrace.ini
:
; extension = ddappsec.so
That being said, the behaviour of the installer is intentional and not a bug.
Got it, thanks for the response. Closing!
Bug report
The
datadog-setup.php
script always extracts thedatadog-profiling.so
andddappsec.so
extensions regardless of the--enable-profiling
and--enable-appsec
arguments.The following Dockerfile:
Demonstrates said behavior:
PHP version
8.2.10
Tracer or profiler version
0.91.2
Installed extensions
Output of
phpinfo()
Upgrading from
No response