Allow synchronous sidecar flushes and reduce flush limit

[bwoebi]

• Synchronous flushing for testing.
• Reduced flush interval for sidecar.
• Reduced flush limit to avoid the sidecar ballooning up memory wise.
• Respect DD_TRACE_AGENT_FLUSH_AFTER_N_REQUESTS with the sidecar active.

[pr-commenter[bot]]

Benchmarks

Benchmark execution time: 2024-06-04 09:30:05

Comparing candidate commit 9bc62f97568218f42d455e500c20c26a4cc0acdc in PR branch bob/sync-flush with baseline commit 7557b8aad57681d2d704cecedea5249f4786d915 in branch master.

Found 8 performance improvements and 1 performance regressions! Performance is the same for 169 metrics, 0 unstable metrics.

scenario:HookBench/benchHookOverheadInstallHookOnFunction

• 🟩 execution_time [-51.168µs; -19.391µs] or [-6.124%; -2.321%]

scenario:HookBench/benchHookOverheadInstallHookOnMethod-opcache

• 🟩 execution_time [-46.777µs; -17.513µs] or [-5.896%; -2.208%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

• 🟥 execution_time [+3.523µs; +5.397µs] or [+2.448%; +3.751%]

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-18.913µs; -17.650µs] or [-9.831%; -9.175%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟩 execution_time [-16.569µs; -13.771µs] or [-8.633%; -7.175%]

scenario:PDOBench/benchPDOOverhead

• 🟩 execution_time [-18.490µs; -16.297µs] or [-6.389%; -5.631%]

scenario:PDOBench/benchPDOOverhead-opcache

• 🟩 execution_time [-17.257µs; -15.194µs] or [-5.842%; -5.144%]

scenario:PDOBench/benchPDOOverheadWithDBM

• 🟩 execution_time [-18.051µs; -16.394µs] or [-5.755%; -5.227%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

• 🟩 execution_time [-15.915µs; -13.959µs] or [-4.911%; -4.307%]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 46.51163% with 23 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (7557b8a) to head (9bc62f9).

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2689 +/- ## ============================================ - Coverage 77.79% 77.77% -0.03% Complexity 2223 2223 ============================================ Files 226 226 Lines 26357 26390 +33 Branches 988 988 ============================================ + Hits 20505 20524 +19 - Misses 5326 5340 +14 Partials 526 526 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.13% <ø> (ø)` | | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.61% <46.51%> (-0.06%)` | :arrow_down: | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `80.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [ext/configuration.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&filepath=ext%2Fconfiguration.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2NvbmZpZ3VyYXRpb24uaA==) | `100.00% <ø> (ø)` | | | [ext/ddtrace\_arginfo.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&filepath=ext%2Fddtrace_arginfo.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2RkdHJhY2VfYXJnaW5mby5o) | `100.00% <ø> (ø)` | | | [ext/hook/uhook\_legacy.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&filepath=ext%2Fhook%2Fuhook_legacy.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2hvb2svdWhvb2tfbGVnYWN5LmM=) | `88.46% <ø> (ø)` | | | [ext/sidecar.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&filepath=ext%2Fsidecar.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L3NpZGVjYXIuYw==) | `88.18% <100.00%> (ø)` | | | [ext/configuration.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&filepath=ext%2Fconfiguration.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2NvbmZpZ3VyYXRpb24uYw==) | `79.48% <86.66%> (+1.70%)` | :arrow_up: | | [ext/auto\_flush.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&filepath=ext%2Fauto_flush.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2F1dG9fZmx1c2guYw==) | `53.76% <0.00%> (-2.42%)` | :arrow_down: | | [ext/ddtrace.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?src=pr&el=tree&filepath=ext%2Fddtrace.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2RkdHJhY2UuYw==) | `74.18% <27.27%> (-0.37%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [7557b8a...9bc62f9](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2689?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).