DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
487 stars 152 forks source link

Implement OTel config remapping #2691

Closed bwoebi closed 3 months ago

bwoebi commented 3 months ago

As per GDoc.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 81.43713% with 31 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (48e857d) to head (89bcbe1).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691/graphs/tree.svg?width=650&height=150&src=pr&token=eXio8H7vwF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2691 +/- ## ============================================ - Coverage 79.33% 77.78% -1.55% Complexity 2223 2223 ============================================ Files 200 227 +27 Lines 22371 26531 +4160 Branches 0 988 +988 ============================================ + Hits 17747 20637 +2890 - Misses 4624 5368 +744 - Partials 0 526 +526 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.13% <ø> (?)` | | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.63% <81.43%> (+<0.01%)` | :arrow_up: | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `80.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [ext/configuration.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=ext%2Fconfiguration.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2NvbmZpZ3VyYXRpb24uaA==) | `100.00% <ø> (ø)` | | | [ext/ddtrace.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=ext%2Fddtrace.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2RkdHJhY2UuaA==) | `62.50% <ø> (ø)` | | | [ext/sidecar.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=ext%2Fsidecar.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L3NpZGVjYXIuYw==) | `88.18% <100.00%> (ø)` | | | [ext/ddtrace.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=ext%2Fddtrace.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2RkdHJhY2UuYw==) | `74.14% <50.00%> (-0.04%)` | :arrow_down: | | [ext/telemetry.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=ext%2Ftelemetry.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L3RlbGVtZXRyeS5j) | `93.33% <83.33%> (-0.52%)` | :arrow_down: | | [zend\_abstract\_interface/config/config.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=zend_abstract_interface%2Fconfig%2Fconfig.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-emVuZF9hYnN0cmFjdF9pbnRlcmZhY2UvY29uZmlnL2NvbmZpZy5j) | `94.11% <84.61%> (-1.38%)` | :arrow_down: | | [zend\_abstract\_interface/config/config\_ini.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=zend_abstract_interface%2Fconfig%2Fconfig_ini.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-emVuZF9hYnN0cmFjdF9pbnRlcmZhY2UvY29uZmlnL2NvbmZpZ19pbmkuYw==) | `73.00% <89.47%> (+0.31%)` | :arrow_up: | | [ext/otel\_config.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?src=pr&el=tree&filepath=ext%2Fotel_config.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L290ZWxfY29uZmlnLmM=) | `79.50% <79.50%> (ø)` | | ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [48e857d...89bcbe1](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2691?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).
pr-commenter[bot] commented 3 months ago

Benchmarks

Benchmark execution time: 2024-06-07 15:02:45

Comparing candidate commit 89bcbe1db522de4de324fc5645f9fb10e969a816 in PR branch bob/otel_cfg_remap with baseline commit 48e857d4afd20e0c27abb2151bdfbd6dee9734a6 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelBaseline-opcache

scenario:MessagePackSerializationBench/benchMessagePackSerialization

scenario:PDOBench/benchPDOOverheadWithDBM