DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
487 stars 152 forks source link

fix: Don't treat Symfony 2 differently from other versions #2693

Closed PROFeNoM closed 3 months ago

PROFeNoM commented 3 months ago

Description

APMS-12365

Reviewer checklist

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.40%. Comparing base (4f9928d) to head (5923046).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693/graphs/tree.svg?width=650&height=150&src=pr&token=eXio8H7vwF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2693 +/- ## ============================================ + Coverage 79.32% 79.40% +0.07% + Complexity 2223 2212 -11 ============================================ Files 201 201 Lines 22514 22488 -26 ============================================ - Hits 17860 17857 -3 + Misses 4654 4631 -23 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.63% <ø> (ø)` | | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `80.52% <100.00%> (+0.19%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [...DTrace/Integrations/Symfony/SymfonyIntegration.php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693?src=pr&el=tree&filepath=src%2FDDTrace%2FIntegrations%2FSymfony%2FSymfonyIntegration.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-c3JjL0REVHJhY2UvSW50ZWdyYXRpb25zL1N5bWZvbnkvU3ltZm9ueUludGVncmF0aW9uLnBocA==) | `89.18% <100.00%> (+5.75%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [4f9928d...5923046](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2693?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).
pr-commenter[bot] commented 3 months ago

Benchmarks

Benchmark execution time: 2024-06-07 18:20:42

Comparing candidate commit 5923046564d2b5a126f063554117c5a2edc43874 in PR branch alex/fix/symfony-2 with baseline commit 4f9928ddbc141ce242c4bac5d3d8a30b2cf8af8b in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

pbowyer commented 3 months ago

Hi, I'm the originator of the APMS ticket. I've had https://github.com/DataDog/dd-trace-php/blob/f29260f1ebaaf063670e2012b627f02f314d06c3/src/DDTrace/Integrations/Symfony/SymfonyIntegration.php running in production for 12 hours (with v1.0.0 of dd-trace-php) and it's giving me proper traces. Many thanks!