search

DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
481 stars 149 forks source link

Hack to massage sidecar v0.7 into what is expected by tests #2694

Closed bantonsson closed 3 weeks ago

bantonsson commented 3 weeks ago

Description

This is dependent on a dev version of the apm test agent https://github.com/DataDog/dd-apm-test-agent/pull/181 that you have to build locally with

docker build --tag testagent .

in that project.

To restart the test agent container only with a newly built local test agent docker image, do:

docker compose up -d test-agent

Reviewer checklist

bantonsson commented 3 weeks ago

So the state right now is that tests keep getting weird array failures like this:

1) DDTrace\Tests\Integration\TracerTest::testResourceNormalizationWebDefault
Undefined array key "resource"

/home/circleci/app/tests/Integration/TracerTest.php:187

But if I insert a print line before the assert

        error_log('Traces v07: ' . print_r($traces, 1));

Then the test works 🤷🏼‍♂️

pr-commenter[bot] commented 3 weeks ago

Benchmarks

Benchmark execution time: 2024-06-05 15:37:53

Comparing candidate commit a11591bb7b2a34f447b4d99ef597c3d795a4cfda in PR branch ban/v07test-updates with baseline commit 0344bb09620d56c6959cb84e3c83db94c46b62ab in branch pierre/enable-sidecar-by-default.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

bwoebi commented 3 weeks ago

Closing this PR and working directly on #2680 to avoid two PRs.