ci(profiling): cleanup correctness tests

DataDog / dd-trace-php

Datadog PHP Clients

https://docs.datadoghq.com/tracing/setup/php

Other

487 stars 152 forks source link

ci(profiling): cleanup correctness tests #2702

Closed realFlowControl closed 3 months ago

realFlowControl commented 3 months ago

Description

This PR adds a check for the timeline feature for missing labels (mostly end_timestamp_ns) and also cleans up the JSON files using jq.

Reviewer checklist

[ ] Test coverage seems ok.
[ ] Appropriate labels assigned.

pr-commenter[bot] commented 3 months ago

Benchmarks

Benchmark execution time: 2024-06-10 18:47:57

Comparing candidate commit c4833df65dbecf92c1ad23b527e1ccf742a81510 in PR branch florian/correctness-tests with baseline commit d4d642dfd2ce05395009cdcc5c17849ffd764521 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

morrisonlevi commented 3 months ago

In this case, we need to fix merge conflicts before I can review.

morrisonlevi commented 3 months ago

The test failures are unrelated:

Starting container mcr.microsoft.com/mssql/server:2022-latest
  image cache not found on this host, downloading mcr.microsoft.com/mssql/server:2022-latest
2022-latest: Pulling from mssql/server
bf5a0d774f7b: Extracting [==================================================>]  31.59MB/31.59MB
db4f0305501a: Downloading 
e4340e72fdf2: Download complete 

error parsing HTTP 429 response body: invalid character 'R' looking for beginning of value: "Ref A: B57B760098974F8795B190B8B564C6D2 Ref B: MNZ221060610023 Ref C: 2024-06-10T18:44:39Z"