Closed PROFeNoM closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.50%. Comparing base (
5869a12
) to head (eff1c80
).
Benchmark execution time: 2024-06-17 13:19:21
Comparing candidate commit eff1c80a72d712fe14bf17e4a76b87cb06b3c1e1 in PR branch alex/aidm/162
with baseline commit 5869a12307680b55cc32077a5641c1bf4789df72 in branch master
.
Found 4 performance improvements and 0 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.
execution_time
[-12.831µs; -5.649µs] or [-5.186%; -2.283%]execution_time
[-18.827µs; -17.666µs] or [-9.733%; -9.133%]execution_time
[-17.982µs; -9.151µs] or [-6.121%; -3.115%]execution_time
[-16.848µs; -7.281µs] or [-5.298%; -2.290%]
Description
AIDM-162
The following system test was failing. This is because from OTel pov, doing
setAttribute
sets the status code in the metrics array.This PR simply maps (and therefore overrides, if set) the deprecated
http.status_code
metric to the meta array.This tag is set in Otel HTTP semantic versions inferior or equal than 1.21.0
Reviewer checklist