DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
481 stars 149 forks source link

ci: add PHP 8.3 to randomized tests #2721

Closed morrisonlevi closed 1 week ago

morrisonlevi commented 2 weeks ago

Description

While working on something else, I realized PHP 8.3 isn't in the randomized test framework yet.

Reviewer checklist

morrisonlevi commented 2 weeks ago

Summary of the core files in this CI run:

Type 1: JIT failures

These have plagued us. I'm not sure what to do, as the cores never help to debug the issue. They look like this:

Core was generated by `php -d opcache.jit_buffer_size=256M -d datadog.trace.log_file=/results/dd_php_e'.
Program terminated with signal SIGABRT, Aborted.
#0  0x0000ffff8148d884 in ?? ()
(gdb) bt
#0  0x0000ffff8148d884 in ?? ()
#1  0x0000ffff8148d814 in ?? ()

Type 2: Sidecar __cxa_finalize

These are new (to me anyway).

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x0000ffffa4224968 in __GI_abort () at abort.c:79
#2  0x0000ffffa4561524 in ?? () from /usr/lib/aarch64-linux-gnu/libasan.so.5
#3  0x0000ffffa4569548 in ?? () from /usr/lib/aarch64-linux-gnu/libasan.so.5
#4  0x0000ffffa456de8c in ?? () from /usr/lib/aarch64-linux-gnu/libasan.so.5
#5  0x0000ffffa456d6c8 in ?? () from /usr/lib/aarch64-linux-gnu/libasan.so.5
#6  0x0000ffffa4239440 in __cxa_finalize (d=0xffffa45d45b0) at cxa_finalize.c:83
#7  0x0000ffffa4499bb0 in ?? () from /usr/lib/aarch64-linux-gnu/libasan.so.5
#8  0x0000ffffa530be1c in _dl_fini () at dl-fini.c:138
#9  0x0000ffffa4238e38 in __run_exit_handlers (status=0, listp=0xffffa436f5c8 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, 
    run_dtors=run_dtors@entry=true) at exit.c:108
#10 0x0000ffffa4238f9c in __GI_exit (status=<optimized out>) at exit.c:139
#11 0x0000ffffa4224da8 in __libc_start_main (main=0xaaaab9150df0, argc=5, argv=0xffffe4874f08, init=<optimized out>, fini=<optimized out>, 
    rtld_fini=<optimized out>, stack_end=<optimized out>) at ../csu/libc-start.c:342
#12 0x0000aaaab9151140 in ?? ()

Type 3: unusable backtraces

These are sometimes truncated and sometimes not. We've been seeing these for a while. I suspect they are related to the JIT but I did not verify these specific ones are.

BFD: warning: /home/circleci/core is truncated: expected core file size >= 265261056, found: 84275200
[New LWP 61142]
Failed to read a valid object file image from memory.
Core was generated by `php-fpm: po'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f96401948eb in ?? ()
(gdb) bt
#0  0x00007f96401948eb in ?? ()
Backtrace stopped: Cannot access memory at address 0x7ffe37a599a0
Core was generated by `php-fpm: po'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f115ed398eb in ?? ()
(gdb) bt
#0  0x00007f115ed398eb in ?? ()
#1  0x0000000000000000 in ?? (

The frames seem to regular end in 8eb.