DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
487 stars 152 forks source link

Add config to disable obfuscation in memcached queries #2725

Closed pablomartinezbernardo closed 3 months ago

pablomartinezbernardo commented 3 months ago

Description

Add config to disable obfuscation in memcached queries. Keeps old behavior by default. Added on both memcache and memcached. Tests for memached cover only one path, but I didn't want to duplicate the number of integration tests.

Reviewer checklist

pr-commenter[bot] commented 3 months ago

Benchmarks

Benchmark execution time: 2024-06-20 15:12:56

Comparing candidate commit 8e2b1b9ac9bb5e55820eba1b29b7dc43f6820936 in PR branch pmartinez/memcached-disable-obfuscation with baseline commit 59d123805767c6a23247985bb50d2bc542bcd4bf in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileOverhead

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

scenario:PDOBench/benchPDOBaseline-opcache