ci(profiling) compatibility with upcoming prof correctness

DataDog / dd-trace-php

Datadog PHP Clients

https://docs.datadoghq.com/tracing/setup/php

Other

481 stars 149 forks source link

ci(profiling) compatibility with upcoming prof correctness #2733

Closed realFlowControl closed 6 days ago

realFlowControl commented 6 days ago

Description

This PR ensures compatibility with https://github.com/DataDog/prof-correctness/pull/43

Reviewer checklist

[ ] Test coverage seems ok.
[ ] Appropriate labels assigned.

r1viollet commented 6 days ago

Thanks for fixing! We can merge to avoid a failure tomorrow morning

pr-commenter[bot] commented 6 days ago

Benchmarks

Benchmark execution time: 2024-06-26 13:39:11

Comparing candidate commit 5f9ddc2bbaf84f4a93e921f0681328b46f6d6f82 in PR branch florian/compat-to-upcomming-correctness with baseline commit 3c0d0f9be2bec0de9a8120857a7d66390352822d in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 9 unstable metrics.

scenario:walk_stack/1

🟩 wall_time [-267.193ns; -264.917ns] or [-2.197%; -2.178%]