WAF telemetry

[cataphract]

Description

See individual commits for descriptions of the changes.

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 36.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.47%. Comparing base (eab1560) to head (5e939e9). Report is 1 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2735 +/- ## ============================================ - Coverage 79.52% 79.47% -0.05% Complexity 2216 2216 ============================================ Files 201 201 Lines 22595 22614 +19 ============================================ + Hits 17969 17973 +4 - Misses 4626 4641 +15 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.74% <36.00%> (-0.09%)` | :arrow_down: | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `80.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [ext/otel\_config.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735?src=pr&el=tree&filepath=ext%2Fotel_config.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L290ZWxfY29uZmlnLmM=) | `79.50% <0.00%> (ø)` | | | [ext/telemetry.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735?src=pr&el=tree&filepath=ext%2Ftelemetry.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L3RlbGVtZXRyeS5j) | `84.41% <37.50%> (-8.92%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [eab1560...5e939e9](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2735?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[pr-commenter[bot]]

Benchmarks

Benchmark execution time: 2024-06-28 14:34:02

Comparing candidate commit 5e939e9e9e54098b431b63e72fb1f76bf33ef9f1 in PR branch glopes/waf-telemetry with baseline commit eab15602d6a77c615ce56f46b16210688d33e94a in branch master.

Found 8 performance improvements and 1 performance regressions! Performance is the same for 169 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchExtractTraceContext128Bit-opcache

• 🟥 mem_peak [+40.515KB; +192.341KB] or [+2.040%; +9.685%]

scenario:EmptyFileBench/benchEmptyFileBaseline

• 🟩 execution_time [-169.042µs; -74.578µs] or [-6.904%; -3.046%]

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-18.167µs; -17.064µs] or [-9.465%; -8.891%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟩 execution_time [-17.179µs; -11.503µs] or [-8.939%; -5.986%]

scenario:PDOBench/benchPDOOverhead

• 🟩 execution_time [-20.465µs; -17.201µs] or [-6.954%; -5.845%]

scenario:PDOBench/benchPDOOverhead-opcache

• 🟩 execution_time [-19.053µs; -17.452µs] or [-6.328%; -5.796%]

scenario:PDOBench/benchPDOOverheadWithDBM

• 🟩 execution_time [-20.445µs; -18.490µs] or [-6.396%; -5.785%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

• 🟩 execution_time [-18.770µs; -16.536µs] or [-5.599%; -4.932%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟩 execution_time [-418.403ns; -141.997ns] or [-5.989%; -2.032%]