Move appsec helper to sidecar

[cataphract]

Description

Runs appsec helper inside sidecar.

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 48.18182% with 57 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (2ec6aab) to head (c1191af). Report is 119 commits behind head on master.

Files with missing lines	Patch %	Lines
appsec/src/extension/helper_process.c	48.00%	19 Missing and 7 partials :warning:
appsec/src/extension/network.c	33.33%	23 Missing and 1 partial :warning:
ext/sidecar.c	50.00%	6 Missing :warning:
ext/coms.c	50.00%	1 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2773 +/- ## ============================================ - Coverage 80.09% 78.66% -1.44% Complexity 2459 2459 ============================================ Files 204 230 +26 Lines 23769 27526 +3757 Branches 0 904 +904 ============================================ + Hits 19038 21653 +2615 - Misses 4731 5383 +652 - Partials 0 490 +490 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.64% <46.80%> (?)` | | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.58% <56.25%> (-0.03%)` | :arrow_down: | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.13% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec/src/extension/commands\_helpers.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fcommands_helpers.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29tbWFuZHNfaGVscGVycy5j) | `69.71% <100.00%> (ø)` | | | [appsec/src/extension/configuration.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fconfiguration.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29uZmlndXJhdGlvbi5o) | `100.00% <ø> (ø)` | | | [appsec/src/extension/ddappsec.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fddappsec.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vZGRhcHBzZWMuYw==) | `73.85% <100.00%> (ø)` | | | [appsec/src/extension/request\_abort.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Frequest_abort.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vcmVxdWVzdF9hYm9ydC5j) | `72.28% <100.00%> (ø)` | | | [ext/configuration.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=ext%2Fconfiguration.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2NvbmZpZ3VyYXRpb24uaA==) | `100.00% <ø> (ø)` | | | [ext/ddtrace.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=ext%2Fddtrace.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2RkdHJhY2UuYw==) | `74.40% <100.00%> (+0.01%)` | :arrow_up: | | [ext/coms.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=ext%2Fcoms.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L2NvbXMuYw==) | `76.37% <50.00%> (+0.06%)` | :arrow_up: | | [ext/sidecar.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=ext%2Fsidecar.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-ZXh0L3NpZGVjYXIuYw==) | `84.45% <50.00%> (-3.05%)` | :arrow_down: | | [appsec/src/extension/network.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fnetwork.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vbmV0d29yay5j) | `43.85% <33.33%> (ø)` | | | [appsec/src/extension/helper\_process.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fhelper_process.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vaGVscGVyX3Byb2Nlc3MuYw==) | `62.23% <48.00%> (ø)` | | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [2ec6aab...c1191af](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2773?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[pr-commenter[bot]]

Benchmarks

Benchmark execution time: 2024-08-03 05:28:05

Comparing candidate commit c1191af00ce8cb30bcedd502c655637bf811579a in PR branch glopes/helper-to-sidecar with baseline commit 2ec6aab365171d86d00403896b5aedb1d8a648cb in branch master.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-17.659µs; -16.461µs] or [-9.489%; -8.846%]

scenario:PDOBench/benchPDOOverhead

• 🟩 execution_time [-19.160µs; -15.152µs] or [-6.622%; -5.237%]

scenario:PDOBench/benchPDOOverheadWithDBM

• 🟩 execution_time [-18.842µs; -13.942µs] or [-6.010%; -4.447%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟥 execution_time [+5.153µs; +7.947µs] or [+2.779%; +4.285%]