Closed iamluc closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.97%. Comparing base (
1ae62ef
) to head (581b9fc
).
Benchmark execution time: 2024-08-29 12:00:33
Comparing candidate commit 581b9fc25cabae80e616f6bb214cb196af016101 in PR branch luc/debug-frankenphp-memleak2
with baseline commit 1ae62ef5cbb7446eb13f3fba40d8928eb4ae67d6 in branch master
.
Found 5 performance improvements and 3 performance regressions! Performance is the same for 170 metrics, 0 unstable metrics.
execution_time
[-42.359ns; -24.308ns] or [-4.044%; -2.321%]execution_time
[+17.611µs; +18.641µs] or [+10.425%; +11.035%]execution_time
[-18.330µs; -9.220µs] or [-9.985%; -5.023%]execution_time
[+15.630µs; +17.386µs] or [+6.061%; +6.742%]execution_time
[-19.175µs; -16.402µs] or [-6.574%; -5.623%]execution_time
[+12.883µs; +17.569µs] or [+4.582%; +6.249%]execution_time
[-20.490µs; -18.728µs] or [-6.246%; -5.709%]execution_time
[-21.746ms; -21.540ms] or [-83.712%; -82.917%]
Description
Our signal handlers probably conflicts with golang, causing memory issues on our reliability environments.
Reviewer checklist