DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
487 stars 152 forks source link

[Bug]: cannot build OFFLINE again #2825

Closed remicollet closed 4 weeks ago

remicollet commented 1 month ago

Bug report

Despite using "cargo vendor" to avoid download during the build

    Blocking waiting for file lock on package cache
warning: spurious network error (2 tries remaining): failed to resolve address for github.com: Temporary failure in name resolution; class=Net (12)
warning: spurious network error (1 tries remaining): failed to resolve address for github.com: Temporary failure in name resolution; class=Net (12)
error: failed to get `blazesym` as a dependency of package `datadog-crashtracker v0.0.1 (/builddir/build/BUILD/php81-php-pecl-datadog-trace-1.3.0-build/php81-php-pecl-datadog-trace-1.3.0/datadog_trace-1.3.0/libdatadog/crashtracker)`

Caused by:
  failed to load source for dependency `blazesym`

Caused by:
  Unable to update https://github.com/libbpf/blazesym.git?rev=v0.2.0-rc.0#2f393f66

Caused by:
  failed to clone into: /builddir/.cargo/git/db/blazesym-44372c3355cb762f

Caused by:
  network failure seems to have happened
  if a proxy or similar is necessary `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  failed to resolve address for github.com: Temporary failure in name resolution; class=Net (12)

Tracer or profiler version

1.2.0

Looks like a regression was OK for 1.1.0

bwoebi commented 1 month ago

Thanks for notifying us - I'll make sure to add some testing around that alongside the actual fixing.

bwoebi commented 1 month ago

Woops, that was autoclosed.

bwoebi commented 1 month ago

Hey @remicollet,

we've generated a new artifact with that dependency fetched from crates.io. And added a check in our CI to prevent that from reoccurring.

Would you mind testing/using https://output.circle-artifacts.com/output/job/11118184-517f-4f90-a55e-5b9dd0dc12b7/artifacts/0/pecl/datadog_trace-1.3.0.tgz this pecl .tar.gz?

Nothing changed in there except the source of that dependency.

Thanks!

remicollet commented 1 month ago

I confirm the fix is OK Thanks

bwoebi commented 4 weeks ago

@remicollet Do you need a fresh tag, or can you just build based on that artifact?

remicollet commented 4 weeks ago

I don't need a new tag (RPM already built)

bwoebi commented 4 weeks ago

Thanks a lot!