[DO NOT MERGE] Temporary branch to test impact of LFI

[estringana]

Description

emporary branch to test impact of LFI

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.84%. Comparing base (05ae627) to head (2ab56af). Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
appsec/src/extension/ddappsec.c	83.33%	0 Missing and 1 partial :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2829 +/- ## ============================================ - Coverage 73.93% 73.84% -0.09% ============================================ Files 173 65 -108 Lines 18679 8358 -10321 Branches 975 976 +1 ============================================ - Hits 13810 6172 -7638 + Misses 4332 1649 -2683 Partials 537 537 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.18% <92.30%> (+0.06%)` | :arrow_up: | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.19% <ø> (ø)` | | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec/src/extension/backtrace.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fbacktrace.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vYmFja3RyYWNlLmM=) | `71.15% <100.00%> (+0.18%)` | :arrow_up: | | [appsec/src/extension/commands/request\_exec.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fcommands%2Frequest_exec.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29tbWFuZHMvcmVxdWVzdF9leGVjLmM=) | `100.00% <100.00%> (ø)` | | | [appsec/src/extension/configuration.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fconfiguration.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29uZmlndXJhdGlvbi5o) | `100.00% <ø> (ø)` | | | [appsec/src/extension/user\_tracking.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fuser_tracking.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vdXNlcl90cmFja2luZy5j) | `71.69% <100.00%> (ø)` | | | [appsec/src/extension/ddappsec.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fddappsec.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vZGRhcHBzZWMuYw==) | `74.88% <83.33%> (+0.79%)` | :arrow_up: | ... and [108 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [05ae627...2ab56af](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2829?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[pr-commenter[bot]]

Benchmarks

Benchmark execution time: 2024-09-02 13:21:57

Comparing candidate commit 2ab56afbca5775ef2b64c180051f6e38fbe55ae8 in PR branch estringana/tmp-lfi with baseline commit 05ae6270e82aa0a170b3ce97f7176a2d3d962d06 in branch master.

Found 8 performance improvements and 31 performance regressions! Performance is the same for 139 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.550%; +9.550%]

scenario:ContextPropagationBench/benchExtractHeaders128Bit

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:ContextPropagationBench/benchExtractHeaders128Bit-opcache

• 🟩 execution_time [-518.548ns; -490.786ns] or [-48.981%; -46.359%]

scenario:ContextPropagationBench/benchExtractHeaders64Bit

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:ContextPropagationBench/benchExtractTraceContext128Bit

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:ContextPropagationBench/benchExtractTraceContext64Bit

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:ContextPropagationBench/benchInject128Bit

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:ContextPropagationBench/benchInject64Bit

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:EmptyFileBench/benchEmptyFileBaseline

• 🟥 execution_time [+97.819µs; +220.901µs] or [+3.938%; +8.894%]

scenario:HookBench/benchHookOverheadInstallHookOnFunction

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:HookBench/benchHookOverheadInstallHookOnMethod

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.548%; +9.548%]

scenario:HookBench/benchHookOverheadTraceFunction

• 🟥 mem_peak [+622.358KB; +622.362KB] or [+17.197%; +17.198%]

scenario:HookBench/benchHookOverheadTraceMethod

• 🟥 mem_peak [+622.296KB; +622.296KB] or [+16.897%; +16.897%]

scenario:HookBench/benchWithoutHook

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.550%; +9.550%]

scenario:LaravelBench/benchLaravelBaseline

• 🟥 execution_time [+110.295µs; +250.945µs] or [+4.222%; +9.605%]

scenario:LaravelBench/benchLaravelOverhead

• 🟥 execution_time [+116.096µs; +254.584µs] or [+4.109%; +9.012%]

scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache

• 🟥 execution_time [+156.427ns; +209.173ns] or [+10.482%; +14.016%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

• 🟥 mem_peak [+495.240KB; +495.240KB] or [+13.911%; +13.911%]

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-12.938µs; -4.542µs] or [-7.296%; -2.561%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟩 execution_time [-18.373µs; -14.974µs] or [-9.938%; -8.099%]

scenario:PDOBench/benchPDOOverhead

• 🟩 execution_time [-16.677µs; -8.478µs] or [-6.188%; -3.146%]

scenario:PDOBench/benchPDOOverhead-opcache

• 🟩 execution_time [-23.896µs; -22.163µs] or [-8.302%; -7.700%]

scenario:PDOBench/benchPDOOverheadWithDBM

• 🟩 execution_time [-16.254µs; -14.182µs] or [-5.506%; -4.804%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

• 🟩 execution_time [-34.290µs; -29.827µs] or [-10.560%; -9.186%]

scenario:SamplingRuleMatchingBench/benchGlobMatching1

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.550%; +9.550%]

scenario:SamplingRuleMatchingBench/benchGlobMatching2

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.550%; +9.550%]

scenario:SamplingRuleMatchingBench/benchGlobMatching3

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.550%; +9.550%]

scenario:SamplingRuleMatchingBench/benchGlobMatching4

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.550%; +9.550%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.549%; +9.549%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.549%; +9.549%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.549%; +9.549%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟥 mem_peak [+331.184KB; +331.184KB] or [+9.549%; +9.549%]

scenario:SpanBench/benchDatadogAPI

• 🟥 mem_peak [+614.967KB; +614.977KB] or [+5.046%; +5.046%]

scenario:SpanBench/benchDatadogAPI-opcache

• 🟥 execution_time [+367.306ns; +802.694ns] or [+2.271%; +4.962%]
• 🟥 mem_peak [+264.493KB; +264.498KB] or [+2.578%; +2.578%]

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead

• 🟥 mem_peak [+622.279KB; +622.282KB] or [+16.859%; +16.859%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟥 execution_time [+75.510µs; +80.190µs] or [+44.470%; +47.226%]
• 🟥 mem_peak [+598.072KB; +598.072KB] or [+17.243%; +17.243%]

scenario:WordPressBench/benchWordPressOverhead

• 🟩 execution_time [-21.603ms; -21.453ms] or [-83.687%; -83.106%]