[DO NOT MERGE] Testing ongoing lfi branch with ongoing benchmarks branch

[estringana]

Description

I will close this PR as soon as I test the benchmarks

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (05ae627) to head (9501bd5). Report is 17 commits behind head on master.

Files with missing lines	Patch %	Lines
appsec/src/extension/ddappsec.c	61.11%	4 Missing and 3 partials :warning:
appsec/src/extension/tags.c	75.00%	1 Missing and 1 partial :warning:
zend_abstract_interface/hook/hook.c	0.00%	2 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2844 +/- ## ============================================ - Coverage 73.93% 73.80% -0.13% ============================================ Files 173 65 -108 Lines 18679 8379 -10300 Branches 975 979 +4 ============================================ - Hits 13810 6184 -7626 + Misses 4332 1655 -2677 - Partials 537 540 +3 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.14% <72.72%> (+0.01%)` | :arrow_up: | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.17% <0.00%> (-0.02%)` | :arrow_down: | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec/src/extension/backtrace.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fbacktrace.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vYmFja3RyYWNlLmM=) | `71.15% <100.00%> (+0.18%)` | :arrow_up: | | [appsec/src/extension/commands/request\_exec.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fcommands%2Frequest_exec.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29tbWFuZHMvcmVxdWVzdF9leGVjLmM=) | `100.00% <100.00%> (ø)` | | | [appsec/src/extension/configuration.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fconfiguration.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29uZmlndXJhdGlvbi5o) | `100.00% <ø> (ø)` | | | [appsec/src/extension/user\_tracking.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fuser_tracking.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vdXNlcl90cmFja2luZy5j) | `71.69% <100.00%> (ø)` | | | [appsec/src/extension/tags.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Ftags.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vdGFncy5j) | `79.80% <75.00%> (-0.07%)` | :arrow_down: | | [zend\_abstract\_interface/hook/hook.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&filepath=zend_abstract_interface%2Fhook%2Fhook.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-emVuZF9hYnN0cmFjdF9pbnRlcmZhY2UvaG9vay9ob29rLmM=) | `54.42% <0.00%> (-0.07%)` | :arrow_down: | | [appsec/src/extension/ddappsec.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fddappsec.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vZGRhcHBzZWMuYw==) | `73.61% <61.11%> (-0.48%)` | :arrow_down: | ... and [108 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [05ae627...9501bd5](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2844?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[pr-commenter[bot]]

Benchmarks [ appsec ]

Benchmark execution time: 2024-09-12 09:11:28

Comparing candidate commit 9501bd574d3e3a11ae63260fa0aab4c70a86b23b in PR branch estringana/tmp-bench-lfi with baseline commit e7adb515242dc130fa967a1b1a1858a86ad8d2c8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

[pr-commenter[bot]]

Benchmarks [ tracer ]

Benchmark execution time: 2024-09-12 06:50:44

Comparing candidate commit 4065548180f9a4d420b9daeba4ebd2d0e32489c7 in PR branch estringana/tmp-bench-lfi with baseline commit e7adb515242dc130fa967a1b1a1858a86ad8d2c8 in branch master.

Found 3 performance improvements and 28 performance regressions! Performance is the same for 147 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.541%; +9.541%]

scenario:ContextPropagationBench/benchExtractHeaders128Bit

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:ContextPropagationBench/benchExtractHeaders64Bit

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:ContextPropagationBench/benchExtractHeaders64Bit-opcache

• 🟥 execution_time [+471.155ns; +508.845ns] or [+54.032%; +58.354%]

scenario:ContextPropagationBench/benchExtractTraceContext128Bit

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:ContextPropagationBench/benchExtractTraceContext64Bit

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:ContextPropagationBench/benchInject128Bit

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:ContextPropagationBench/benchInject64Bit

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:HookBench/benchHookOverheadInstallHookOnFunction

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:HookBench/benchHookOverheadInstallHookOnMethod

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:HookBench/benchHookOverheadTraceFunction

• 🟥 mem_peak [+621.461KB; +621.466KB] or [+17.162%; +17.162%]

scenario:HookBench/benchHookOverheadTraceMethod

• 🟥 mem_peak [+621.399KB; +621.402KB] or [+16.862%; +16.862%]

scenario:HookBench/benchWithoutHook

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.541%; +9.541%]

scenario:LogsInjectionBench/benchLogsInfoInjection-opcache

• 🟥 execution_time [+256.943ns; +504.657ns] or [+3.361%; +6.602%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

• 🟥 mem_peak [+494.344KB; +494.344KB] or [+13.876%; +13.876%]

scenario:PDOBench/benchPDOOverhead-opcache

• 🟩 execution_time [-11.744µs; -7.471µs] or [-3.854%; -2.452%]

scenario:SamplingRuleMatchingBench/benchGlobMatching1

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.541%; +9.541%]

scenario:SamplingRuleMatchingBench/benchGlobMatching1-opcache

• 🟩 execution_time [-140.384ns; -49.816ns] or [-6.063%; -2.151%]

scenario:SamplingRuleMatchingBench/benchGlobMatching2

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.541%; +9.541%]

scenario:SamplingRuleMatchingBench/benchGlobMatching3

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.541%; +9.541%]

scenario:SamplingRuleMatchingBench/benchGlobMatching4

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.541%; +9.541%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟥 mem_peak [+331.072KB; +331.072KB] or [+9.539%; +9.539%]

scenario:SpanBench/benchDatadogAPI

• 🟥 mem_peak [+614.075KB; +614.082KB] or [+5.038%; +5.038%]

scenario:SpanBench/benchDatadogAPI-opcache

• 🟥 mem_peak [+263.915KB; +263.922KB] or [+2.572%; +2.572%]

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead

• 🟥 mem_peak [+621.382KB; +621.389KB] or [+16.825%; +16.825%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟥 execution_time [+84.873µs; +92.127µs] or [+49.416%; +53.640%]
• 🟥 mem_peak [+597.176KB; +597.176KB] or [+17.206%; +17.206%]

scenario:WordPressBench/benchWordPressOverhead

• 🟩 execution_time [-22.090ms; -21.779ms] or [-83.202%; -82.031%]