DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
487 stars 152 forks source link

Loader: disable the tracer in case of a potential incompatibility (extension/jit) #2853

Closed iamluc closed 4 days ago

iamluc commented 2 weeks ago

Description

Reviewer checklist

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.41%. Comparing base (3746a2f) to head (98fc95f).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853/graphs/tree.svg?width=650&height=150&src=pr&token=eXio8H7vwF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2853 +/- ## ============================================ + Coverage 78.39% 78.41% +0.01% Complexity 2526 2526 ============================================ Files 173 173 Lines 18710 18713 +3 Branches 976 976 ============================================ + Hits 14667 14673 +6 + Misses 3506 3503 -3 Partials 537 537 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.08% <ø> (ø)` | | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.26% <100.00%> (+0.08%)` | :arrow_up: | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [zend\_abstract\_interface/hook/hook.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853?src=pr&el=tree&filepath=zend_abstract_interface%2Fhook%2Fhook.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-emVuZF9hYnN0cmFjdF9pbnRlcmZhY2UvaG9vay9ob29rLmM=) | `54.98% <100.00%> (+0.55%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [3746a2f...98fc95f](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2853?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).
pr-commenter[bot] commented 1 week ago

Benchmarks [ tracer ]

Benchmark execution time: 2024-09-19 16:25:56

Comparing candidate commit 98fc95f5143f70b500c893a780948b19a3b1b685 in PR branch luc/loader-incompat-extensions with baseline commit 3746a2f68f64484dd2b0f62228e615b3b960513d in branch master.

Found 5 performance improvements and 4 performance regressions! Performance is the same for 169 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelBaseline

scenario:LaravelBench/benchLaravelOverhead

scenario:PDOBench/benchPDOBaseline

scenario:PDOBench/benchPDOBaseline-opcache

scenario:PDOBench/benchPDOOverhead

scenario:PDOBench/benchPDOOverhead-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching4

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

scenario:WordPressBench/benchWordPressOverhead