DataDog / dd-trace-php

Datadog PHP Clients
https://docs.datadoghq.com/tracing/setup/php
Other
503 stars 156 forks source link

build(profiling): bump to Rust 1.76 #2876

Closed morrisonlevi closed 1 month ago

morrisonlevi commented 1 month ago

Description

Bumps the profiler to Rust 1.76 from 1.71. The CI images were previously bumped to Rust 1.76 because of a miscompilation issue.

Reviewer checklist

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.91%. Comparing base (b23438e) to head (40a8587).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876/graphs/tree.svg?width=650&height=150&src=pr&token=eXio8H7vwF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2876 +/- ## ============================================ + Coverage 78.23% 80.91% +2.68% Complexity 2526 2526 ============================================ Files 173 146 -27 Lines 18742 14711 -4031 Branches 981 0 -981 ============================================ - Hits 14662 11903 -2759 + Misses 3540 2808 -732 + Partials 540 0 -540 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.10% <ø> (ø)` | | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.09% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. [see 28 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [b23438e...40a8587](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2876?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).
pr-commenter[bot] commented 1 month ago

Benchmarks [ profiler ]

Benchmark execution time: 2024-10-10 12:00:04

Comparing candidate commit 40a8587c052d4920a9e9021a99b1d8ed1fa62807 in PR branch levi/prof-rust-1.76 with baseline commit b23438e2473f607de9f1ca998cdaf679dff1e31c in branch master.

Found 5 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 9 unstable metrics.

scenario:walk_stack/50

scenario:walk_stack/99

scenario:walk_stack_instructions/1

scenario:walk_stack_instructions/50

scenario:walk_stack_instructions/99

remicollet commented 1 month ago

Looks like this break build on RHEL and clones (rust 1.75) see #2882