Closed bwoebi closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.21%. Comparing base (
65d305a
) to head (7230f6d
). Report is 2 commits behind head on master.
Benchmark execution time: 2024-10-14 02:34:12
Comparing candidate commit 7230f6d60b1627fca81c37ff3ac9b53885a51183 in PR branch bob/zend-signals-dsiabled
with baseline commit 65d305a07c65e8df487a51a7061ae1ed2e1a2449 in branch master
.
Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.
execution_time
[-14.444µs; -13.543µs] or [-7.440%; -6.976%]execution_time
[-27.820µs; -16.030µs] or [-3.803%; -2.191%]
I seem to have taken care about the globals, but missed zend_signal_handler_unblock.
Also adding a test for that scenario.