Implements ASM standalone billing

estringana commented 1 month ago

Description

Work in progress...

Reviewer checklist

[ ] Test coverage seems ok.
[ ] Appropriate labels assigned.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (f5c5729) to head (8131ed0). Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
appsec/src/extension/ddappsec.c	12.50%	3 Missing and 4 partials :warning:
appsec/src/extension/tags.c	50.00%	6 Missing and 1 partial :warning:
appsec/src/extension/commands_helpers.c	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891/graphs/tree.svg?width=650&height=150&src=pr&token=eXio8H7vwF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog)](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2891 +/- ## ============================================ + Coverage 78.21% 78.26% +0.04% Complexity 2526 2526 ============================================ Files 173 173 Lines 18749 18764 +15 Branches 988 993 +5 ============================================ + Hits 14664 14685 +21 + Misses 3544 3535 -9 - Partials 541 544 +3 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `68.64% <34.78%> (+0.26%)` | :arrow_up: | | [tracer-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `78.10% <ø> (ø)` | | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.09% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec/src/extension/configuration.h](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fconfiguration.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29uZmlndXJhdGlvbi5o) | `100.00% <ø> (ø)` | | | [appsec/src/extension/commands\_helpers.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fcommands_helpers.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vY29tbWFuZHNfaGVscGVycy5j) | `70.05% <0.00%> (ø)` | | | [appsec/src/extension/ddappsec.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Fddappsec.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vZGRhcHBzZWMuYw==) | `67.93% <12.50%> (-2.64%)` | :arrow_down: | | [appsec/src/extension/tags.c](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?src=pr&el=tree&filepath=appsec%2Fsrc%2Fextension%2Ftags.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-YXBwc2VjL3NyYy9leHRlbnNpb24vdGFncy5j) | `79.17% <50.00%> (-0.70%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [f5c5729...8131ed0](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2891?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

pr-commenter[bot] commented 1 month ago

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-18 08:05:53

Comparing candidate commit 8131ed0e31cd4cd055fe177bdb7ee271cdd097d2 in PR branch estringana/asm-standalone with baseline commit f5c5729bdef259ed801bee949ac38b0217b8451b in branch master.

Found 2 performance improvements and 7 performance regressions! Performance is the same for 169 metrics, 0 unstable metrics.

scenario:BM_TeaSapiSpinup

🟥 execution_time [+56.821µs; +126.466µs] or [+3.999%; +8.900%]

scenario:ContextPropagationBench/benchInject64Bit

🟥 execution_time [+377.596ns; +754.404ns] or [+4.944%; +9.878%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

🟩 execution_time [-6.796µs; -4.804µs] or [-3.987%; -2.818%]

scenario:PDOBench/benchPDOBaseline

🟩 execution_time [-13.475µs; -9.813µs] or [-7.077%; -5.153%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

🟥 execution_time [+142.686ns; +504.514ns] or [+2.056%; +7.271%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

🟥 execution_time [+246.449ns; +591.151ns] or [+3.631%; +8.709%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

🟥 execution_time [+490.529ns; +810.071ns] or [+7.204%; +11.897%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

🟥 execution_time [+254.284ns; +506.116ns] or [+3.800%; +7.564%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

🟥 execution_time [+242.568ns; +489.432ns] or [+3.618%; +7.300%]

pr-commenter[bot] commented 1 month ago

Benchmarks [ appsec ]

Benchmark execution time: 2024-10-18 08:13:22

Comparing candidate commit 8131ed0e31cd4cd055fe177bdb7ee271cdd097d2 in PR branch estringana/asm-standalone with baseline commit f5c5729bdef259ed801bee949ac38b0217b8451b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

DataDog / dd-trace-php