ASM Standalone

[estringana]

Description

Implement ASM Standalone billing. This project will enable customers to use ASM product without APM product.

Implementation

There is a new configuration called DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED(default: false) which disable APM.

When DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED is enabled, traces will be only sent under the following conditions:

• There is an ASM event
• One APM trace will be sent as a heartbeat at least once a minute in the absence of ASM events. This is done to keep the service alive on the backend and avoid it gets into degraded mode.

Since the tracing engine is coupled to the tracer extension, it will be required that DD_TRACE_ENABLED is set to true. However DD_TRACE_ENABLED being enabled does not mean APM is.

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.82%. Comparing base (6280989) to head (d251733). Report is 22 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2903 +/- ## ========================================= Coverage 74.82% 74.82% Complexity 2741 2741 ========================================= Files 110 110 Lines 10863 10863 ========================================= Hits 8128 8128 Misses 2735 2735 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2903/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `74.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2903?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2903?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [6280989...d251733](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2903?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[pr-commenter[bot]]

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-29 17:28:17

Comparing candidate commit d25173302443facf326e7c510f9d68481328b666 in PR branch estringana/asm-standalone-2 with baseline commit 628098978c1574cc6bd8ce3b9233046adba81ece in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

• 🟥 execution_time [+4.547µs; +6.173µs] or [+2.758%; +3.744%]

scenario:TraceFlushBench/benchFlushTrace

• 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-11.665µs; -6.935µs] or [-5.664%; -3.367%]

[pr-commenter[bot]]

Benchmarks [ appsec ]

Benchmark execution time: 2024-11-29 17:36:11

Comparing candidate commit d25173302443facf326e7c510f9d68481328b666 in PR branch estringana/asm-standalone-2 with baseline commit 628098978c1574cc6bd8ce3b9233046adba81ece in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.