Update spdlog so it works with recent musls

[cataphract]

https://github.com/gabime/spdlog/commit/287a00d364990edbb621fe5e392aeb550135fb96

Description

Reviewer checklist

• [ ] Test coverage seems ok.
• [ ] Appropriate labels assigned.

[bwoebi]

That probably fixed that particular issue, but now a load of new errors appear, probably due to the other changes between these commits...

And please rebase the commit on top of a newer master, CI fails too much too :-)

[cataphract]

Rebase and fixed the errors related to the new spdlog, at least in the main helper binary.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.39%. Comparing base (352d3ba) to head (f34823a).

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2921?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2921 +/- ## ========================================= Coverage 72.39% 72.39% Complexity 2526 2526 ========================================= Files 135 135 Lines 14400 14400 Branches 989 989 ========================================= Hits 10425 10425 Misses 3433 3433 Partials 542 542 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2921/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2921/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `68.36% <ø> (ø)` | | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2921/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `73.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2921?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2921?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [352d3ba...f34823a](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2921?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[pr-commenter[bot]]

Benchmarks [ appsec ]

Benchmark execution time: 2024-11-04 19:18:36

Comparing candidate commit f34823afd1f653397bea43e1c727d7606616f88b in PR branch glopes/update-spdlog with baseline commit 352d3babf9588fcfbc9726232f0a2594b17dede8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

[Anilm3]

The integration tests are failing because they're expecting an image for PHP 8.4 which doesn't exist at the moment, you can disable the 8.4 test for now and I'll add this to the backlog.