Avoid the hook frame in mysqli connection error tracking

[bwoebi]

Otherwise the error stems from "Mysqli/MysqliIntegration.php:379" which may be confusing and seemingly hint at a problem in our integrations.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.08%. Comparing base (a9d4274) to head (8ca7d66). Report is 1 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ```diff @@ Coverage Diff @@ ## master #2937 +/- ## ============================================ + Coverage 78.28% 82.08% +3.80% Complexity 2527 2527 ============================================ Files 135 108 -27 Lines 14398 10360 -4038 Branches 989 0 -989 ============================================ - Hits 11271 8504 -2767 + Misses 2584 1856 -728 + Partials 543 0 -543 ``` | [Flag](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [appsec-extension](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `?` | | | [tracer-php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.08% <100.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [.../DDTrace/Integrations/Mysqli/MysqliIntegration.php](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937?src=pr&el=tree&filepath=src%2FDDTrace%2FIntegrations%2FMysqli%2FMysqliIntegration.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog#diff-c3JjL0REVHJhY2UvSW50ZWdyYXRpb25zL015c3FsaS9NeXNxbGlJbnRlZ3JhdGlvbi5waHA=) | `87.02% <100.00%> (+0.10%)` | :arrow_up: | ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Last update [a9d4274...8ca7d66](https://app.codecov.io/gh/DataDog/dd-trace-php/pull/2937?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog).

[pr-commenter[bot]]

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-07 17:40:02

Comparing candidate commit 8ca7d66be462082f27778ae7d24509332f404c41 in PR branch bob/mysqli_error_stack with baseline commit a9d427486fed49053b3bd7351c57dc6c4214d3b8 in branch master.

Found 4 performance improvements and 3 performance regressions! Performance is the same for 171 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

• 🟥 execution_time [+84.377µs; +207.603µs] or [+2.874%; +7.072%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

• 🟥 execution_time [+104.232µs; +214.568µs] or [+3.217%; +6.623%]

scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache

• 🟩 execution_time [-80.762ns; -36.238ns] or [-5.051%; -2.266%]

scenario:PDOBench/benchPDOBaseline

• 🟥 execution_time [+14.849µs; +15.836µs] or [+8.356%; +8.911%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟩 execution_time [-14.870µs; -13.924µs] or [-7.703%; -7.213%]

scenario:TraceFlushBench/benchFlushTrace-opcache

• 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-10.203µs; -5.397µs] or [-5.296%; -2.802%]