search

DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
532 stars 408 forks source link

Falcon ASGI support #10446

Open lattwood opened 2 weeks ago

lattwood commented 2 weeks ago

It appears as though the current version of the Falcon integration only has sync methods.

https://github.com/DataDog/dd-trace-py/blob/16f2960b01178da325dec61c67ac3dd50137573e/ddtrace/contrib/internal/falcon/middleware.py

According to the Falcon docs, in order to support ASGI apps as well as WSGI apps, there needs to be *_async postfix methods in the TraceMiddleware.

https://falcon.readthedocs.io/en/stable/api/middleware.html

emmettbutler commented 2 weeks ago

Thanks for pointing this out, @lattwood. We'll add it to our backlog of feature requests and it will be included in a future prioritization pass.

cc @mabdinur