chore(profiling): fix sanitizers on Linux

sanchda commented 1 week ago

In order for our tests to work with sanitizers,

sanitizer lib needs to be propagated from the test fixture to the dynamic libraries (e.g., dd_wrapper) (this was broken due to underspecifying the link type)
dynamic linker needs to be able to find the .so; the way we did it worked OK on macos, but on Linux the libs are actually in a subdir

Checklist

[X] PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

[x] Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions[bot] commented 1 week ago

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/cmake/AnalysisFunc.cmake             @DataDog/profiling-python

pr-commenter[bot] commented 1 week ago

Benchmarks

Benchmark execution time: 2024-11-16 03:41:13

Comparing candidate commit 902b8de3f59fc7ec006cfcbff886dbd591e50203 in PR branch sanchda/fix_libsan with baseline commit 8e9edd3c18a7dcd96a6b0482981c12fca902a13c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

sanchda commented 1 week ago

/merge

dd-devflow[bot] commented 1 week ago

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-15 21:07:13 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

2024-11-15 21:07:17 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

2024-11-16 01:07:19 UTC :warning: MergeQueue: This merge request was unqueued

This merge request was unqueued

sanchda commented 6 days ago

/merge

dd-devflow[bot] commented 6 days ago

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-16 02:56:57 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

2024-11-16 02:57:00 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

2024-11-16 03:43:34 UTC :information_source: MergeQueue: merge request added to the queue

The median merge time in main is 35m.

DataDog / dd-trace-py