DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
553 stars 416 forks source link

chore(crashtracker): add profiler_config tag if profiler enabled #11430

Closed taegyunkim closed 4 days ago

taegyunkim commented 1 week ago

The previous attempt set the tag after crashtracker has started, and tags didn't show up in the logs.

Checklist

Reviewer Checklist

github-actions[bot] commented 1 week ago

CODEOWNERS have been resolved as:

ddtrace/internal/core/crashtracking.py                                  @DataDog/apm-core-python
ddtrace/profiling/profiler.py                                           @DataDog/profiling-python
ddtrace/settings/profiling.py                                           @DataDog/profiling-python
tests/internal/crashtracker/test_crashtracker.py                        @DataDog/apm-core-python
datadog-dd-trace-py-rkomorn[bot] commented 1 week ago

Datadog Report

Branch report: taegyunkim/crashtracker-profiler-config Commit report: bc549ae Test service: dd-trace-py

:white_check_mark: 0 Failed, 1468 Passed, 0 Skipped, 26m 10.08s Total duration (12m 0.77s time saved)

pr-commenter[bot] commented 1 week ago

Benchmarks

Benchmark execution time: 2024-11-21 19:13:09

Comparing candidate commit a5a04a7c1aebb058399497feeda4bd624e387e28 in PR branch taegyunkim/crashtracker-profiler-config with baseline commit d792c3dc3c7452ed64524ea38d0b9c9116330a73 in branch main.

Found 2 performance improvements and 4 performance regressions! Performance is the same for 382 metrics, 2 unstable metrics.

scenario:iast_aspects-ljust_aspect

scenario:iast_aspects-ospathbasename_aspect

scenario:iast_aspects-ospathjoin_aspect

scenario:iast_aspects-rsplit_aspect

scenario:iast_aspects-split_aspect

scenario:iast_aspects-upper_aspect