Closed taegyunkim closed 4 days ago
CODEOWNERS
have been resolved as:
ddtrace/internal/core/crashtracking.py @DataDog/apm-core-python
ddtrace/profiling/profiler.py @DataDog/profiling-python
ddtrace/settings/profiling.py @DataDog/profiling-python
tests/internal/crashtracker/test_crashtracker.py @DataDog/apm-core-python
Branch report: taegyunkim/crashtracker-profiler-config
Commit report: bc549ae
Test service: dd-trace-py
:white_check_mark: 0 Failed, 1468 Passed, 0 Skipped, 26m 10.08s Total duration (12m 0.77s time saved)
Benchmark execution time: 2024-11-21 19:13:09
Comparing candidate commit a5a04a7c1aebb058399497feeda4bd624e387e28 in PR branch taegyunkim/crashtracker-profiler-config
with baseline commit d792c3dc3c7452ed64524ea38d0b9c9116330a73 in branch main
.
Found 2 performance improvements and 4 performance regressions! Performance is the same for 382 metrics, 2 unstable metrics.
execution_time
[+1.451µs; +1.556µs] or [+10.461%; +11.220%]execution_time
[+555.407ns; +599.398ns] or [+16.702%; +18.025%]execution_time
[+463.758ns; +526.577ns] or [+9.095%; +10.327%]execution_time
[-196.418ns; -165.813ns] or [-10.206%; -8.616%]execution_time
[-215.894ns; -186.554ns] or [-11.519%; -9.953%]execution_time
[+219.238ns; +251.825ns] or [+7.946%; +9.127%]
The previous attempt set the tag after crashtracker has started, and tags didn't show up in the logs.
Checklist
Reviewer Checklist