DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
552 stars 416 forks source link

ci: use fixtures to reset dd-trace-debug and caplog level #11437

Closed gnufede closed 2 days ago

gnufede commented 4 days ago

Since these tests are flaky, this PR is intended to test the most important thing and let the additional asserts pass but not fail the test to avoid too many retries.

Checklist

Reviewer Checklist

github-actions[bot] commented 4 days ago

CODEOWNERS have been resolved as:

tests/tracer/test_endpoint_config.py                                    @DataDog/apm-sdk-api-python
pr-commenter[bot] commented 4 days ago

Benchmarks

Benchmark execution time: 2024-11-20 08:07:26

Comparing candidate commit 9c34e643a93d1163d3cb243ce6f5a1f071203a72 in PR branch gnufede/flaky_test_endpoint_config with baseline commit 5724fd30074245127c3ce9f47a7a38c0714c5165 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

romainkomorndatadog commented 3 days ago

I wonder if passing the logger argument (eg: the docs show logger="root.baz") would make this a tiny bit safer as well.