Closed sanchda closed 5 days ago
CODEOWNERS
have been resolved as:
ddtrace/releasenotes/notes/fix-profiler-memalloc-init-f097d604fb2af519.yaml @DataDog/apm-python
ddtrace/profiling/profiler.py @DataDog/profiling-python
Benchmark execution time: 2024-11-18 17:59:57
Comparing candidate commit 7ac81aa13181dd861dd5f06b4ba16d9a88c463fe in PR branch sanchda/fix_memalloc_init
with baseline commit 343ba22bbe4010edb9206950fca5dc21c35d3d58 in branch main
.
Found 3 performance improvements and 0 performance regressions! Performance is the same for 385 metrics, 2 unstable metrics.
execution_time
[-236.396ns; -201.062ns] or [-8.906%; -7.575%]execution_time
[-595.803ns; -537.658ns] or [-8.256%; -7.450%]execution_time
[-182.833ns; -145.773ns] or [-10.006%; -7.978%]Only semi-related, you can mostly ignore this: When reading Collector
I thought this was an implementation of some unused/free memory collector, not a class to get memory data, maybe MemorySampler
or something similar would be a better name?
The current implementation of this system has a pretty negligent state initialization sequence.
In particular, the memory allocation profiler relies on libdatadog in some circumstances, and should be initialized after it.
Checklist
Reviewer Checklist