chore(testing): fix snapshot failures

wconti27 commented 2 days ago

Fixes snapshot failures. these tests were previously passing due to differences in run commands between feature branches and main. The difference between test scripts has been reconciled.

Checklist

[x] PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

[x] Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions[bot] commented 2 days ago

CODEOWNERS have been resolved as:

scripts/run-test-suite                                                  @DataDog/apm-core-python
tests/snapshots/tests.contrib.aiomysql.test_aiomysql.test_queries.json  @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_bad_connect.json  @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_bad_query.json  @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_connect.json    @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_connection_methods.json  @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_cursor.json     @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_cursor_manual.json  @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_parenting.json  @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_select.json     @DataDog/apm-python
tests/snapshots/tests.contrib.asyncpg.test_asyncpg.test_service_override_pin.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_class_based_handlers[ClassHandler-class_handler].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_class_based_handlers[StaticHandler-static_handler].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_class_based_handlers[handler2-instance_handler].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_class_based_handlers[handler3-instance_handler_with_code].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_continue_on_early_trace_ending.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_file_patching.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_module_patching.json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_timeout_traces[-100].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_timeout_traces[100].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_timeout_traces[10].json  @DataDog/apm-python
tests/snapshots/tests.contrib.aws_lambda.test_aws_lambda.test_timeout_traces[200].json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_eventbridge.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_kinesis.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_s3.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_s3_invalid_config.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_s3_valid_config.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_sns.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_sns_valid_config.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_sqs.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_ai21_invoke.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_amazon_embedding.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_amazon_invoke.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_amazon_invoke_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_anthropic_invoke.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_anthropic_invoke_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_anthropic_message_invoke.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_anthropic_message_invoke_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_auth_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_cohere_embedding.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_cohere_invoke_multi_output.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_cohere_invoke_single_output.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_cohere_invoke_stream_multi_output.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_cohere_invoke_stream_multiple_output.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_cohere_invoke_stream_single_output.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_meta_invoke.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_meta_invoke_stream.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_read_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_read_stream_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.botocore.test_bedrock.test_readlines_error.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_analytics_with_rate_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_analytics_with_rate_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_analytics_without_rate_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_analytics_without_rate_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_commit_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_commit_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_many_fetchall_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_many_fetchall_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_proc_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_proc_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_with_several_rows_fetchall_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_with_several_rows_fetchall_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_with_several_rows_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_query_with_several_rows_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_simple_malformed_query_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_simple_malformed_query_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_simple_query_fetchall_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_simple_query_fetchall_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_simple_query_snapshot_post_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.mariadb.test_mariadb.test_simple_query_snapshot_pre_1_1.json  @DataDog/apm-python
tests/snapshots/tests.contrib.psycopg.test_psycopg.test_composed_query_encoding.json  @DataDog/apm-python
tests/snapshots/tests.contrib.psycopg2.test_psycopg.test_composed_query_encoding.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_context.test_otel_ddtrace_mixed_parenting.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_context.test_otel_multithreading.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_context.test_otel_span_parenting.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_context.test_otel_trace_across_fork.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_context.test_otel_trace_multiple_coroutines.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_context.test_sampling_decisions_across_processes[manual.drop].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_context.test_sampling_decisions_across_processes[manual.keep].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_attributes.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_attributes_overrides[override0].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_attributes_overrides[override1].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_attributes_overrides[override2].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_attributes_overrides[override3].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_attributes_overrides[override4].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_attributes_overrides[override5].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_events.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_span.test_otel_span_kind.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_trace.test_distributed_trace_with_flask_app[with_ddtrace_run].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_trace.test_distributed_trace_with_flask_app[with_opentelemetry_instrument].json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_trace.test_otel_start_current_span_with_default_args.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_trace.test_otel_start_current_span_without_default_args.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_trace.test_otel_start_span_ignore_exceptions.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_trace.test_otel_start_span_record_exception.json  @DataDog/apm-python
tests/snapshots/tests.opentelemetry.test_trace.test_otel_start_span_without_default_args.json  @DataDog/apm-python

wconti27 commented 2 days ago

/merge

wconti27 commented 2 days ago

/merge

dd-devflow[bot] commented 2 days ago

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-20 15:16:40 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

2024-11-20 15:39:04 UTC :information_source: MergeQueue: merge request added to the queue

The median merge time in main is 35m.

dd-devflow[bot] commented 2 days ago

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-20 15:16:44 UTC :x: MergeQueue

PR already in the queue with status waiting

pr-commenter[bot] commented 2 days ago

Benchmarks

Benchmark execution time: 2024-11-20 15:36:53

Comparing candidate commit d49a0cbb1e39df08808e87daf0dfb38b3b55f247 in PR branch conti/fix-service-naming-snapshots with baseline commit c26fd4c9dffa1c8f083db729462d2b2286c60ddb in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 387 metrics, 2 unstable metrics.

scenario:iast_aspects-splitlines_aspect

🟥 execution_time [+134.675ns; +162.857ns] or [+7.923%; +9.581%]

DataDog / dd-trace-py