DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
553 stars 416 forks source link

chore(tracing): fix some service naming tests that were failing silently #11483

Closed wconti27 closed 14 hours ago

wconti27 commented 4 days ago

Motivation

See silent failures here.

Checklist

Reviewer Checklist

github-actions[bot] commented 4 days ago

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/bottle/trace.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/botocore/test.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
datadog-dd-trace-py-rkomorn[bot] commented 4 days ago

Datadog Report

Branch report: conti/update-service-naming-algo Commit report: 1844a4e Test service: dd-trace-py

:white_check_mark: 0 Failed, 10 Passed, 1368 Skipped, 55.92s Total duration (35m 13.04s time saved)

pr-commenter[bot] commented 4 days ago

Benchmarks

Benchmark execution time: 2024-11-25 19:40:27

Comparing candidate commit addb591b171db2b15e20624be0d4739351b4e4af in PR branch conti/update-service-naming-algo with baseline commit b5b6dd0634d7027d7056239978de2de2abfdb930 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

wconti27 commented 4 days ago

/merge

dd-devflow[bot] commented 4 days ago

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-21 16:09:29 UTC :information_source: MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2024-11-21 17:27:29 UTC :x: MergeQueue: The checks failed on this merge request

Tests failed on this commit 3f108e5:

What to do next?

erikayasuda commented 4 days ago

/merge

dd-devflow[bot] commented 4 days ago

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-21 22:28:46 UTC :information_source: MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-11-21 22:55:29 UTC :x: MergeQueue: The checks failed on this merge request

Tests failed on this commit 25ca482:

What to do next?

wconti27 commented 16 hours ago

/merge

dd-devflow[bot] commented 16 hours ago

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-25 18:16:45 UTC :information_source: MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2024-11-25 18:19:10 UTC :x: MergeQueue: This merge request was updated

This PR is rejected because it was updated

wconti27 commented 14 hours ago

/merge

dd-devflow[bot] commented 14 hours ago

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-25 19:32:25 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.


2024-11-25 19:42:40 UTC :information_source: MergeQueue: merge request added to the queue

The median merge time in main is 35m.