DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
552 stars 416 forks source link

fix(asm): standalone missing tag [backport 2.17] #11489

Closed github-actions[bot] closed 6 hours ago

github-actions[bot] commented 1 day ago

Backport 832301c414f483356fb16409b9a548864fe7e261 from #11452 to 2.17.

This fix resolves a possibly missing ASM standalone tag on root spans. It was only detected previously on uwsgi on nightly system tests.

APPSEC-55222

Checklist

Reviewer Checklist

github-actions[bot] commented 1 day ago

CODEOWNERS have been resolved as:

releasenotes/notes/fix_asm_standalone_span_tag-60b38c1d9d2efbaa.yaml    @DataDog/apm-python
ddtrace/_trace/processor/__init__.py                                    @DataDog/apm-sdk-api-python
datadog-dd-trace-py-rkomorn[bot] commented 1 day ago

Datadog Report

Branch report: backport-11452-to-2.17 Commit report: a302bcc Test service: dd-trace-py

:white_check_mark: 0 Failed, 592 Passed, 694 Skipped, 19m 29.58s Total duration (17m 0.7s time saved)

pr-commenter[bot] commented 1 day ago

Benchmarks

Benchmark execution time: 2024-11-22 15:08:35

Comparing candidate commit a302bcc1c85cf2c41c55a5838e5eac735535561e in PR branch backport-11452-to-2.17 with baseline commit b4abd06b55135a88eeaa152a30380450762a2080 in branch 2.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.