DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
548 stars 411 forks source link

support pytest-bdd>=6.1 #4492

Closed mabdinur closed 1 year ago

mabdinur commented 1 year ago

Summary of problem

Which version of dd-trace-py are you using?

Effected versions: ddtrace>=1.3

Which version of pip are you using?

Not applicable

Which libraries and their versions are you using?

pytest-bdd>=6.1

How can we reproduce your problem?

Run ddtrace pytest-bdd tests with pytest-bdd>=6.1.

First Failure

Second Failure

What is the result that you get?

CI failures

What is the result that you expected?

No CI Failures

majorgreys commented 1 year ago

Discussed with @mabdinur offline.

We need to fix the library documentation which does not include pytest_bdd in the integration version support table and should be consistent with #4486.

nsfrias commented 1 year ago

Hi all,

Is there a workaround for this issue?

I am still getting the error:

(stack excerpt)

AttributeError: module 'pytest_bdd' has no attribute '__version__'

I am using: pytest-bdd==6.1.1 ddtrace==1.13.3

nsfrias commented 1 year ago

@majorgreys Thank you for addressing this issue.

Do you have any idea when the build is going to be released ?

gnufede commented 1 year ago

@majorgreys Thank you for addressing this issue.

Do you have any idea when the build is going to be released ?

@nsfrias you can test already it by using this RC: https://pypi.org/project/ddtrace/1.17.0rc1/

romainkomorndatadog commented 1 year ago

@nsfrias Is the repo you're using our pytest-bdd plugin with public, by any chance?

I created a small test repo for myself to test with this release, but it only has a couple of simple scenarios. I've also tested with some bits of https://github.com/AutomationPanda/behavior-driven-python , but that repo hasn't seen activity in a couple of years.

Having something to test against that's both substantial and recent would be great.