DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
506 stars 398 forks source link

Set service name for boto3/botocore from env var #9040

Open HoneyryderChuck opened 2 months ago

HoneyryderChuck commented 2 months ago

Summary of problem

Several other client libs support service name overrides from env var (DD_AREDIS_SERVICE, DD_PSYCOPG_SERVICE, DD_HTTPX_SERVICE), but there's no such env var support for overriding botocore service name (currently it's "aws.sqs", "aws.s3"...)

In fact, patching

Which version of dd-trace-py are you using?

I've searched on "latest" docs, and found nothing. But I'm using boto3-1.33.13 and botocore-1.33.13.

How can we reproduce your problem?

import ddtrace
ddtrace.config.botocore["service_name"] = "bang"
ddtrace.patch(botocore=True)
# now try sending a message with SQS or smth..

What is the result that you get?

service name was not overridden (still "aws.sqs").

What is the result that you expected?

service name "bang".

emmettbutler commented 2 months ago

cc @tabgok