DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
506 stars 397 forks source link

fix(celery): ensure error.message tag does not include stacktrace #9585

Closed wconti27 closed 2 weeks ago

wconti27 commented 2 weeks ago

Motivation

User reported that the celery exception traceback was being included in the error.message span tag. The error was due to us using the whole exception class, which includes the traceback, to set as the error message, instead of just the exception message. Updated test to ensure just error message is returned.

Checklist

Reviewer Checklist

datadog-dd-trace-py-rkomorn[bot] commented 2 weeks ago

Datadog Report

Branch report: conti/fix-celery-error-message Commit report: efbb86d Test service: dd-trace-py

:white_check_mark: 0 Failed, 237 Passed, 39 Skipped, 23m 15.65s Total duration (1.08s time saved)

pr-commenter[bot] commented 2 weeks ago

Benchmarks

Benchmark execution time: 2024-06-18 18:17:51

Comparing candidate commit ed0feff206fc101e5eeaed24e65363b75ca3e535 in PR branch conti/fix-celery-error-message with baseline commit c0bc1eb92f79a1fd5dd82a838e5923c437ee77a1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.