DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
506 stars 397 forks source link

fix(celery): ensure error.message tag does not include stacktrace [backport 2.10] #9591

Closed github-actions[bot] closed 1 week ago

github-actions[bot] commented 2 weeks ago

Backport 16f3f951addfad0ba3b65235e601a9c101f273c6 from #9585 to 2.10.

Motivation

User reported that the celery exception traceback was being included in the error.message span tag. The error was due to us using the whole exception class, which includes the traceback, to set as the error message, instead of just the exception message. Updated test to ensure just error message is returned.

Checklist

Reviewer Checklist

datadog-dd-trace-py-rkomorn[bot] commented 2 weeks ago

Datadog Report

Branch report: backport-9585-to-2.10 Commit report: 70bbbb0 Test service: dd-trace-py

:white_check_mark: 0 Failed, 194 Passed, 82 Skipped, 22m 2.2s Total duration (51.24s time saved)

pr-commenter[bot] commented 2 weeks ago

Benchmarks

Benchmark execution time: 2024-06-19 08:27:41

Comparing candidate commit d8d0c2a85937ed41524197528905a1eb790526ee in PR branch backport-9585-to-2.10 with baseline commit 70b27a25aa12e4b5dc46a542f7d36c41dd332f73 in branch 2.10.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 184 metrics, 0 unstable metrics.