DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
506 stars 397 forks source link

chore(iast): fix propagation for `platformdirs` #9593

Closed gnufede closed 1 week ago

gnufede commented 1 week ago

IAST: Removes the detection and later patching skipping of loaded third-party modules. This change increases the coverage of propagation, so only Python standard libraries (Python batteries) and the ones included in the deny list are not patched.

Checklist

Reviewer Checklist

datadog-dd-trace-py-rkomorn[bot] commented 1 week ago

Datadog Report

Branch report: gnufede/APPSEC-53675-fix-propagation-platformdirs-rsa Commit report: bbaadc4 Test service: dd-trace-py

:white_check_mark: 0 Failed, 112678 Passed, 1003 Skipped, 50m 17.43s Total duration (9m 1.65s time saved)

pr-commenter[bot] commented 1 week ago

Benchmarks

Benchmark execution time: 2024-06-25 12:42:29

Comparing candidate commit 7f3578862e88f74e80e3d61d44e544516eee5c1e in PR branch gnufede/APPSEC-53675-fix-propagation-platformdirs-rsa with baseline commit 0babcb1198f754f6cd37fda7d00287bef8110e1c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.