Closed Yun-Kim closed 1 week ago
Branch report: yunkim/llmobs-fix-typing-documents
Commit report: cf1d582
Test service: dd-trace-py
:white_check_mark: 0 Failed, 764 Passed, 39629 Skipped, 35m 59.3s Total duration (59m 48.69s time saved)
Benchmark execution time: 2024-06-20 21:32:35
Comparing candidate commit 3567c335565341b9eb3757dbe9e6ec586d789ae0 in PR branch yunkim/llmobs-fix-typing-documents
with baseline commit 099aa7647058c1b9e3c4dd68ab7733e12e721bd3 in branch main
.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 205 metrics, 9 unstable metrics.
Resolves #9600.
This PR addresses the incorrect typing hint in the
ddtrace.llmobs.utils.py
Documents constructor. The documents constructor currently accepts integer/float values for the document score field, but the typing specifies only string field values. The typing fix resolves this inconsistency.Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist