DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
506 stars 397 forks source link

Add admission controller to documentation #9606

Closed florianmutter closed 1 day ago

florianmutter commented 1 week ago

A lot of time the documentation says what to do if you use ddtrace-run. It would help if it would mention somewhere if using the admission controller means you are using ddtrace-run or not.

emmettbutler commented 4 days ago

Hi @florianmutter, and thanks for pointing this out. The documentation here provides the piece of information you're looking for, albeit not in a very clear way.

What it means is that the admission controller and ddtrace-run use the same entrypoint and are not intended to have any meaningful differences.

Are there any specific bits of documentation that mention "if you use ddtrace-run..." that you think would benefit from clarification along these lines?

florianmutter commented 2 days ago

Thank you very much. This is already very helpful. I did not know this documentation and did only look at this page https://ddtrace.readthedocs.io/en/stable/installation_quickstart.html and could not see any mention of kubernets, adminssion or library injection.

It says for example:

When ddtrace-run cannot be used, a similar start-up behavior can be achieved with the import of ddtrace.auto.

But to me it was not clear if you are supposed to use ddtrace.auto or not if you use the admission controller.

emmettbutler commented 1 day ago

@florianmutter glad it's been helpful so far. Hopefully https://github.com/DataDog/dd-trace-py/pull/9681 addresses your questions more directly.