DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
506 stars 397 forks source link

feat(origin detection): implement new spec #9622

Open wdhif opened 1 week ago

wdhif commented 1 week ago

What does this PR do?

Implements the new Origin Detection spec.

Motivation

This is needed to improve Origin Detection with specific edges cases such as Kata Containers while also improving both backward compatibility and future-proofness.

Additional Notes

This change were already discussed internally as part of the RFC regarding New Origin Detection Spec.

Possible Drawbacks / Trade-offs

None

Describe how to test/QA your changes

Unit tests were either modified or added to reflect changes.

Checklist

Reviewer Checklist

datadog-dd-trace-py-rkomorn[bot] commented 1 week ago

Datadog Report

Branch report: CONTP-19/wassim.dhif/implement-new-origin-detection-spec Commit report: 811f4bf Test service: dd-trace-py

:white_check_mark: 0 Failed, 150222 Passed, 22098 Skipped, 8h 34m 48.69s Total duration (34m 25.17s time saved)

pr-commenter[bot] commented 2 days ago

Benchmarks

Benchmark execution time: 2024-07-01 11:05:27

Comparing candidate commit 811f4bfb839c005caf1e4eeb84fe4e73c78b5937 in PR branch CONTP-19/wassim.dhif/implement-new-origin-detection-spec with baseline commit 9c9b5a7e9d5977438cb98a6d86cf00b23f7fa3ff in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.