DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
506 stars 397 forks source link

fix(rc): do not use multiprocessing.Queue when gevent is patched #9626

Open brettlangdon opened 1 week ago

brettlangdon commented 1 week ago

Gevent is not compatible with multiprocessing.Queue.

Detect when gevent is patched and do no use the extra services multiprocessing.Queue

Checklist

Reviewer Checklist

pr-commenter[bot] commented 1 week ago

Benchmarks

Benchmark execution time: 2024-07-01 13:49:11

Comparing candidate commit bc0fb2d3edbe06aa65aaf2d3d90f6ce8254a8910 in PR branch brettlangdon/fix.gevent.rc with baseline commit 9c9b5a7e9d5977438cb98a6d86cf00b23f7fa3ff in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

datadog-dd-trace-py-rkomorn[bot] commented 6 days ago

Datadog Report

Branch report: brettlangdon/fix.gevent.rc Commit report: bc0fb2d Test service: dd-trace-py

:white_check_mark: 0 Failed, 175095 Passed, 1194 Skipped, 11h 49m 35.81s Total duration (14m 19.84s time saved)