ci: downgrade pip to 24.0 for httpx

DataDog / dd-trace-py

Datadog Python APM Client

https://ddtrace.readthedocs.io/

Other

504 stars 396 forks source link

ci: downgrade pip to 24.0 for httpx #9639

Closed gnufede closed 5 days ago

gnufede commented 5 days ago

HTTPX 0.22.0 requirements.txt uses a notation not compatible with latest pip (24.1).

This PR downgrades pip to 24.0 before trying to install HTTPX requirements.

Checklist

[x] Change(s) are motivated and described in the PR description
[x] Testing strategy is described if automated tests are not included in the PR
[x] Risks are described (performance impact, potential for breakage, maintainability)
[x] Change is maintainable (easy to change, telemetry, documentation)
[x] Library release note guidelines are followed or label changelog/no-changelog is set
[x] Documentation is included (in-code, generated user docs, public corp docs)
[x] Backport labels are set (if applicable)
[x] If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

[x] Title is accurate
[x] All changes are related to the pull request's stated goal
[x] Description motivates each change
[x] Avoids breaking API changes
[x] Testing strategy adequately addresses listed risks
[x] Change is maintainable (easy to change, telemetry, documentation)
[x] Release note makes sense to a user of the library
[x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
[x] Backport labels are set in a manner that is consistent with the release branch maintenance policy

datadog-dd-trace-py-rkomorn[bot] commented 5 days ago

Datadog Report

Branch report: gnufede/fix-httpx-requirements Commit report: eb618b0 Test service: dd-trace-py

:x: 15 Failed (0 Known Flaky), 146927 Passed, 28952 Skipped, 8h 59m 50.87s Total duration (1h 43m 2.16s time saved)

:x: Failed Tests (15)

This report shows up to 5 failed tests.

test_on_executor_custom_kwarg - test_executor_decorator.py - Details

<details>
<summary>Expand for error</summary>

```
assert 'tornado-web' == None
 +  where None = <Span(id=14220652976120611136,trace_id=136224765245392302334051487321592793017,parent_id=17371284440727787282,name=tornado.executor.with)>.service
```
</details>

test_on_executor_custom_kwarg - test_executor_decorator.py - Details

Expand for error
``` assert 'tornado-web' == None + where None = .service ```
test_on_executor_exception_handler - test_executor_decorator.py - Details

Expand for error
``` assert 'tornado-web' == None + where None = .service ```
test_on_executor_exception_handler - test_executor_decorator.py - Details

Expand for error
``` assert 'tornado-web' == None + where None = .service ```
test_on_executor_handler - test_executor_decorator.py - Details

Expand for error
``` assert 'tornado-web' == None + where None = .service ```

pr-commenter[bot] commented 5 days ago

Benchmarks

Benchmark execution time: 2024-06-26 11:35:31

Comparing candidate commit eb618b055bd4426e0848b5b018ca0a4deca227b6 in PR branch gnufede/fix-httpx-requirements with baseline commit 3010fa1b350f12fb0f38272c8e54acd343459053 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

github-actions[bot] commented 5 days ago

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport-9639-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03650f8b59624561d33b0d138503a6bd700e8518
# Push it to GitHub
git push --set-upstream origin backport-9639-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport-9639-to-2.7.

github-actions[bot] commented 5 days ago

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8 2.8
# Navigate to the new working tree
cd .worktrees/backport-2.8
# Create a new branch
git switch --create backport-9639-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03650f8b59624561d33b0d138503a6bd700e8518
# Push it to GitHub
git push --set-upstream origin backport-9639-to-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport-9639-to-2.8.

github-actions[bot] commented 5 days ago

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport-9639-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03650f8b59624561d33b0d138503a6bd700e8518
# Push it to GitHub
git push --set-upstream origin backport-9639-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport-9639-to-2.9.

github-actions[bot] commented 5 days ago

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport-9639-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03650f8b59624561d33b0d138503a6bd700e8518
# Push it to GitHub
git push --set-upstream origin backport-9639-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport-9639-to-2.10.