DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
504 stars 396 forks source link

chore(tornado): fix failing tornado test cases #9654

Closed brettlangdon closed 4 days ago

brettlangdon commented 4 days ago

Fix failing tornado jobs.

When we updated the ThreadPoolExecutor implementation to pass Context instead of Span one piece of information we are not passing along is the current Span's "service".

We do not need this since spans created within the ThreadPoolExecutor will use the DD_SERVICE that is set.

These tests do not set a DD_SERVICE so it is expected that their service names are None (will inherit from their parent).

Checklist

Reviewer Checklist

datadog-dd-trace-py-rkomorn[bot] commented 4 days ago

Datadog Report

Branch report: brettlangdon/tornado.ci Commit report: ac1f5df Test service: dd-trace-py

:white_check_mark: 0 Failed, 156 Passed, 342 Skipped, 3m 26.66s Total duration (2m 5.6s time saved)