DataDog / dd-trace-py

Datadog Python APM Client
https://ddtrace.readthedocs.io/
Other
542 stars 411 forks source link

chore(profiling): update libdatadog to v10 and add crashtracker support #9671

Closed sanchda closed 2 months ago

sanchda commented 3 months ago

PROF-10246

APMLP-127

This PR adds crashtracker support and some tests. This isn't yet able to be enabled at the product level.

I'll set up the support in a separate PR, this one was just getting way too ridiculously long.

No user-facing changes, so I'm thinking of not publishing a changelog. This PR does not enable crashtracker.

Checklist

Reviewer Checklist

pr-commenter[bot] commented 3 months ago

Benchmarks

Benchmark execution time: 2024-07-03 01:20:52

Comparing candidate commit 448cb4da397114e2472878f329e4cc253008d36b in PR branch sanchda/libdatadog7 with baseline commit 8598ade4330359d7ba9cafd6f351bad408571186 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

datadog-dd-trace-py-rkomorn[bot] commented 2 months ago

Datadog Report

Branch report: sanchda/libdatadog7 Commit report: 585da8d Test service: dd-trace-py

:white_check_mark: 0 Failed, 117234 Passed, 59554 Skipped, 4h 17m 20.25s Total duration (5h 45m 35.07s time saved)

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 69 lines in your changes missing coverage. Please review.

Project coverage is 10.45%. Comparing base (b21d904) to head (585da8d). Report is 3 commits behind head on main.

Files Patch % Lines
ddtrace/settings/crashtracker.py 0.00% 25 Missing :warning:
ddtrace/settings/profiling.py 0.00% 20 Missing :warning:
...nternal/datadog/profiling/crashtracker/__init__.py 0.00% 8 Missing :warning:
ddtrace/internal/datadog/profiling/util.py 0.00% 7 Missing :warning:
tests/profiling/test_profiler.py 0.00% 3 Missing :warning:
...dtrace/internal/datadog/profiling/ddup/__init__.py 0.00% 2 Missing :warning:
ddtrace/internal/datadog/profiling/types.py 0.00% 2 Missing :warning:
ddtrace/profiling/profiler.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9671 +/- ## =========================================== - Coverage 74.60% 10.45% -64.16% =========================================== Files 1385 1356 -29 Lines 128327 126312 -2015 =========================================== - Hits 95744 13204 -82540 - Misses 32583 113108 +80525 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.