fix(profiling): add debug asserts for our assumption on the stack frame

taegyunkim commented 3 months ago

Checklist

[x] Change(s) are motivated and described in the PR description
[x] Testing strategy is described if automated tests are not included in the PR
[x] Risks are described (performance impact, potential for breakage, maintainability)
[x] Change is maintainable (easy to change, telemetry, documentation)
[x] Library release note guidelines are followed or label changelog/no-changelog is set
[x] Documentation is included (in-code, generated user docs, public corp docs)
[x] Backport labels are set (if applicable)
[x] If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

[x] Title is accurate
[x] All changes are related to the pull request's stated goal
[x] Description motivates each change
[x] Avoids breaking API changes
[x] Testing strategy adequately addresses listed risks
[x] Change is maintainable (easy to change, telemetry, documentation)
[x] Release note makes sense to a user of the library
[x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
[x] Backport labels are set in a manner that is consistent with the release branch maintenance policy

datadog-dd-trace-py-rkomorn[bot] commented 3 months ago

Datadog Report

Branch report: taegyunkim/lock-asserts Commit report: 1a42a60 Test service: dd-trace-py

:white_check_mark: 0 Failed, 175319 Passed, 1179 Skipped, 11h 29m 53.36s Total duration (27m 16.57s time saved) :snowflake: 1 New Flaky

New Flaky Tests (1)

test_iter_events_multi_thread - test_memalloc.py - Last Failure

Expand for error
``` assert 766 >= 1000 ```

pr-commenter[bot] commented 3 months ago

Benchmarks

Benchmark execution time: 2024-07-01 17:58:12

Comparing candidate commit 1a42a6090efedb5b324f82f67fff1f4f7bcee76d in PR branch taegyunkim/lock-asserts with baseline commit 9c9b5a7e9d5977438cb98a6d86cf00b23f7fa3ff in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 27.23%. Comparing base (4acfde7) to head (6f18866). Report is 13 commits behind head on main.

:exclamation: Current head 6f18866 differs from pull request most recent head 1a42a60

Please upload reports for the commit 1a42a60 to get more accurate results.

Files	Patch %	Lines
tests/profiling/collector/test_threading.py	0.00%	49 Missing :warning:
ddtrace/profiling/collector/_lock.py	0.00%	10 Missing :warning:
ddtrace/settings/profiling.py	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9672 +/- ## =========================================== - Coverage 74.65% 27.23% -47.42% =========================================== Files 1381 1370 -11 Lines 127965 127928 -37 =========================================== - Hits 95531 34843 -60688 - Misses 32434 93085 +60651 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

taegyunkim commented 3 months ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#9688
#9672 👈
#9687
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @taegyunkim and the rest of your teammates on Graphite

taegyunkim commented 3 months ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#9688
#9672 👈
#9687
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @taegyunkim and the rest of your teammates on Graphite

taegyunkim commented 3 months ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#9688
#9672 👈
#9687
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @taegyunkim and the rest of your teammates on Graphite

DataDog / dd-trace-py