DataDog / dd-trace-rb

Datadog Tracing Ruby Client
https://docs.datadoghq.com/tracing/
Other
304 stars 370 forks source link

Ignore classes option for Error Tracking #3068

Open ryush00 opened 1 year ago

ryush00 commented 1 year ago

Is your feature request related to a problem? Please describe.

While there are some errors that can be ignored to a certain extent, such as 404 errors, some 4XX errors should not be ignored.

Compared to other error tracking platforms, while other platforms allow you to ignore certain error classes, datadog ignores all 4XX errors by default. I think this is a bad practice.

If a client writes code incorrectly and gets an error like 422, and it's ignored because it's a 4XX error, it's going to make it harder to trace the error and more likely to cause a failure.

Or, like me, they might wonder why some errors aren't being tracked.

Describe the goal of the feature

It would be much better if we could set which classes to ignore via settings.

Describe alternatives you've considered

It was hardcoded, so there's no alternative options.

Additional context

benoittgt commented 8 months ago

Hello @ryush00 šŸ¤—

Thanks for the detailed feature request. I started looking into that. Thanks for the links too. I love the very complet implementation made in sentry-ruby with various handling to get constant. Good work Stan šŸ˜.

My todo list:

Edit 1:

I don't think it's a good. Idea I think it's better to make it global and increment default ignored exceptions with plugged integrations.

benoittgt commented 7 months ago

I started to work on this, but before going further. I think we need to hear what would be wanted from dd-trace-rb maintainers.

For example, we could ignore some exceptions on Rails part but still because it's a 5xx it could be grabbed by in the rack tracing part.